Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed20ca50f1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| At minimum, select the two prepared deployments and the declared controller | ||
| command. This uses an `80` by `24` terminal and grants no workload endpoints: |
There was a problem hiding this comment.
A reader following this preparation section top-to-bottom is told to run controlled-session before the subsequent stage and build commands have created the referenced deployments, so the new minimum example fails at this point. The same invocation is already documented under Run a session; keep this section focused on creating the deployments or place the run example after the preparation steps.
Useful? React with 👍 / 👎.
Make --columns and --rows optional as a pair, defaulting omitted dimensions to 80 by 24 while rejecting partial overrides. Clarify the public host invocation inputs and expand the controlled-session guide with a user-view actor diagram, ordered integration examples, and explicit controller/workload sandbox boundaries. Place sandboxed agents with the projects they execute in the workload while retaining only a small trusted session driver in the controller. Update the controlled-session design, tests, and changelog fragment.
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Make
--columnsand--rowsoptional as a pair, defaulting omitted dimensionsto 80 by 24 while rejecting partial overrides.
Clarify the public host invocation inputs and expand the controlled-session
guide with a user-view actor diagram, ordered integration examples, and
explicit controller/workload sandbox boundaries. Place sandboxed agents with
the projects they execute in the workload while retaining only a small trusted
session driver in the controller.
Update the controlled-session design, tests, and changelog fragment.