Conversation
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2222795 to
fb4dac1
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb4dac1e2d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c01ea7ef8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb6cb2e209
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c7faf4182e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10c05fb703
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4e7ca98ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b709b28c6e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8f2ef9816
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f831885c82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Select Podman for exact and bounded-range mapping profiles, define exclusive per-installation private mappings and the trusted supervisor capability boundary, and record identity-policy, sandbox, isolation, capability, and lifecycle conformance requirements before product integration. Require Docker Engine rejection, reject external bind mounts until safe input and ownership contracts exist, and require identifiable seccomp-policy evidence while deferring public schema and production runtime behavior to later reviewed slices.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3210a486d4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| 10. **Bounded resource use.** Where the selected host and runtime support the | ||
| corresponding controls, every application workload has explicit process, | ||
| memory, CPU, temporary-storage, and output bounds. The resolved and | ||
| effective policy agree, and exceeding a bound is contained without | ||
| exhausting host or peer-workload capacity. |
There was a problem hiding this comment.
When a selected Podman host lacks even one control—such as rootless cgroup delegation or temporary-storage quotas—the amended conditional wording imposes no fail-closed outcome, and SB-03 likewise tests only hosts where controls are supported. An implementation could therefore admit an untrusted workload without that bound and still satisfy the ledger, despite resource exhaustion being in the threat model; require admission to fail before mutation when every required bound cannot be enforced, or explicitly exclude such hosts from this profile.
Useful? React with 👍 / 👎.
| | ID-01 | Every mapped identity has exclusively delegated subordinate host authority only; it does not alias host root, a local or NSS-provided host principal, or a subordinate range delegated to another host principal. | 1 | Host-side mapping inspection and authoritative collision checks against the host identity inventory and every other subordinate UID/GID delegation, plus explicit collision-failure cases and an in-container identity probe for each profile. | Unproven; repeated conformance probe pending | | ||
| | ID-02 | The trusted supervisor can perform every required declared transition and rejects mapped-but-undeclared UIDs, GIDs, and supplementary groups; every application child's final supplementary-group vector contains exactly its declared groups; a separate raw bounded-range mechanism probe permits representative other in-range transitions. | 1 | Positive declared-identity and negative mapped-but-undeclared tests through the production supervisor policy, final `Groups:` inspection that excludes inherited privileged, runtime-required, and otherwise undeclared groups, plus an independently identified raw range-mechanism probe. | Unproven; repeated conformance probe pending | | ||
| | ID-03 | Exact mappings reject every unmapped transition; bounded ranges reject every out-of-range transition; capability-dropped children cannot change identity or regain authority through set-ID or file-capability execution. | 1 | Profile-specific boundary and post-drop tests for `setuid`, `setreuid`, `setresuid`, `setfsuid`, `setgid`, `setregid`, `setresgid`, `setfsgid`, `setgroups`, set-user/group-ID execution, and file-capability execution. | Unproven; repeated conformance probe pending | | ||
| | ID-04 | Two installations using the same container IDs have distinct host mappings, PID and IPC namespaces, and private `/dev/shm` mounts; they cannot observe, signal, or ptrace each other's processes, use each other's System V or named POSIX shared-memory and semaphore objects, use each other's System V message queues, or read each other's private state. | 1 | Concurrent two-workload probe with host mapping, PID-namespace, IPC-namespace, and `/dev/shm` mount inspection plus negative process visibility, signaling, ptrace, System V IPC, POSIX `shm_open`/`sem_open`, and private-state access tests. | Unproven; repeated conformance probe pending | |
There was a problem hiding this comment.
If an implementation shares a network namespace between workloads but filters IP traffic, the required PID/IPC namespace checks and negative TCP/UDP probes can all pass while both workloads still share Linux's abstract Unix-domain socket namespace. That permits an undeclared cross-workload channel despite the narrow-sharing requirement; require distinct network-namespace inspection and a negative abstract-socket connection probe.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Firewall support will come later.
Select Podman for exact and bounded-range mapping profiles, define exclusive per-installation private mappings and the trusted supervisor capability boundary, and record identity-policy, sandbox, isolation, capability, and lifecycle conformance requirements before product integration.
Require Docker Engine rejection, reject external bind mounts until safe input and ownership contracts exist, and require identifiable seccomp-policy evidence while deferring public schema and production runtime behavior to later reviewed slices.