[+] Support lunar birthdays - #356
Merged
Merged
Conversation
Misaka13514
force-pushed
the
feat-lunar
branch
from
February 27, 2026 07:23
0f4b937 to
60044c4
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Adds lunar birthday support to the data build pipeline so people can be marked as having a lunar birthday and have lunar dates derived/displayed during site data generation.
Changes:
- Add
lunar-typescriptdependency and lockfile entry. - Extend
scripts/build.tsto compute lunar month/day forbirthday-list.jsonand to format/display lunar birthdays (while preserving the original solar birthdate separately). - Mark specific people records as
lunar_birthday: true.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
package.json |
Adds lunar-typescript dependency needed for solar↔lunar conversion. |
yarn.lock |
Locks lunar-typescript resolution/integrity for installs. |
scripts/build.ts |
Implements lunar birthday conversion + output adjustments (birthday list + per-person info output). |
people/Y1Ran/info.yml |
Flags this person as having a lunar birthday. |
people/Katerina/info.yml |
Flags this person as having a lunar birthday. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Twinsherry
self-requested a review
February 27, 2026 19:15
Twinsherry
approved these changes
Feb 27, 2026
Contributor
|
お疲れ~ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with:
https://github.com/one-among-us/Morning/pull/1
one-among-us/web#76