FPGA Reg Sample readme update#1610
Merged
Merged
Conversation
Restructured to match new template-with adjustments for FPGA samples. Updated readme sample name to match the sample.json sample name. Moved images into assets folder. Updated some branding. Corrected some formatting issues. Make grammar and spelling corrections.
ghost
requested a review
from 
ghost
added
yuguen
reviewed
May 3, 2023
Contributor
yuguen
left a comment
yuguen
left a comment
There was a problem hiding this comment.
I think we should keep the name of the sample aligned with the actual compiler feature "fpga_reg"
…DME.md Co-authored-by: yuguen-intel <yohann.uguen@intel.com>
…DME.md Co-authored-by: yuguen-intel <yohann.uguen@intel.com>
…DME.md Co-authored-by: yuguen-intel <yohann.uguen@intel.com>
…DME.md Co-authored-by: yuguen-intel <yohann.uguen@intel.com>
yuguen
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existing Sample Changes
Description
Restructured to match new template-with adjustments for FPGA samples. Updated readme sample name to match the sample.json sample name. Moved images into assets folder. Updated some branding. Corrected some formatting issues. Make grammar and spelling corrections.
Fixes Issue#
External Dependencies
N/A
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration