FPGA: Update Tutorials to support Agilex5#2313
Merged
jimmytwei merged 5 commits intooneapi-src:developmentfrom May 2, 2024
Merged
FPGA: Update Tutorials to support Agilex5#2313jimmytwei merged 5 commits intooneapi-src:developmentfrom
jimmytwei merged 5 commits intooneapi-src:developmentfrom
Conversation
whitepau
suggested changes
May 2, 2024
There was a problem hiding this comment.
DEVICE_FLAG is not used by the code sample, it can be removed from CMakeLists.txt. You can leave this for another PR if you like.
Contributor
Author
There was a problem hiding this comment.
I will open a separate PR to handle these changes
justin-rosner
force-pushed
the
development-vendor-seldom
branch
from
c6169c5 to
b8aac93
Compare
yuguen
reviewed
May 10, 2024
Comment on lines
+175
to
+178
| elseif(DEVICE_FLAG MATCHES Agilex5) | ||
| set(FAMILY "Agilex 5") | ||
| else() | ||
| set(FAMILY "Agilex") | ||
| set(FAMILY "Agilex7") |
Contributor
There was a problem hiding this comment.
I think that this is incorrect, based on the fact that Agilex 5 and 7 are not written in the same way.
For this sample, I think that this should have been Agilex for when matching both Agilex5 and Agilex7
Contributor
Author
There was a problem hiding this comment.
I'll open up an additional PR to address this issue.
yuguen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change adds support for Agilex5 to all the tutorials FPGA samples.
External Dependencies
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
I manually ran all of the tutorials with the Agilex5 flag.