fix issues : no crash for parsing a large log file and IPS#00555843#382
Merged
Conversation
JoeOster
suggested changes
Dec 1, 2020
Contributor
JoeOster
left a comment
JoeOster
left a comment
There was a problem hiding this comment.
Please update the description of the PR for future auditing purposes
Contributor
Author
|
could you remind me what I should do for "Please update the description of the PR for future auditing purposes"? |
JoeOster
previously approved these changes
Dec 2, 2020
Contributor
Author
|
json file is under below folder. anything missing? |
Contributor
All is good, we are not merging currently except for a couple of specific things |
louie-tsai
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change includes enablement for the oneDNN tutorial support a large oneDNN log file.
Without this change, the tutorial will crash when users input a large oneDNN log file.
This change also includes a fix for IPS#00555843. The issue only happens on DevCloud. Users wouldn't face any runtime issues on their local machine.
Type of change
Please delete options that are not relevant. Add a 'X' to the one that is applicable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration