Skip to content

fix: manage display token filter issues#1046

Merged
jaymengxy merged 1 commit intodevelopfrom
verified_token
May 13, 2025
Merged

fix: manage display token filter issues#1046
jaymengxy merged 1 commit intodevelopfrom
verified_token

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #1036

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy added this to the Release 2.8.5 milestone May 13, 2025
@jaymengxy jaymengxy requested a review from lealobanov May 13, 2025 06:10
@jaymengxy jaymengxy self-assigned this May 13, 2025
@jaymengxy jaymengxy requested a review from a team as a code owner May 13, 2025 06:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2025

PR Summary

Enhanced token filtering functionality by fixing display token list issues, improving verified token filtering, and adding dust token management features. Added a new help dialog to explain dust token filtering, updated favicon loading, and improved token selection UI.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt Fixed display token list filtering by preserving snapshot before clearing list, ensuring proper filtering for both verified and dust tokens.
app/src/main/java/com/flowfoundation/wallet/page/browser/Utils.kt Changed favicon loading URL from custom CDN to DuckDuckGo's icon service for better reliability.
app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt Added persistent state for verified token filter and improved token list posting logic.
app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt Set verified token switch to checked by default.
app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt Removed unnecessary provider refresh and updated token list fetching method.
app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt New dialog implementation to explain dust token filtering functionality.
app/src/main/java/com/flowfoundation/wallet/page/token/manage/presenter/ManageTokenPresenter.kt Integrated help icon click handler to show dust token explanation dialog.
app/src/main/res/drawable/ic_question.xml New question mark icon asset for dust token help feature.
app/src/main/res/layout/activity_manage_token.xml Added help icon and improved layout constraints for token management filters.
app/src/main/res/layout/dialog_hide_dust_token_tip.xml New dialog layout for explaining dust token filtering feature.
app/src/main/res/layout/dialog_select_token.xml Updated padding and background styling for better visual appearance.
app/src/main/res/values/strings.xml Added new string for dust token tip and simplified dust token label.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 8cea364: fix: manage display token filter issues
Files Processed (12)
  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/browser/Utils.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/manage/presenter/ManageTokenPresenter.kt (3 hunks)
  • app/src/main/res/drawable/ic_question.xml (1 hunk)
  • app/src/main/res/layout/activity_manage_token.xml (3 hunks)
  • app/src/main/res/layout/dialog_hide_dust_token_tip.xml (1 hunk)
  • app/src/main/res/layout/dialog_select_token.xml (2 hunks)
  • app/src/main/res/values/strings.xml (2 hunks)
Actionable Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt [15-15]

    possible bug: "Potential null pointer exception in dialog handling"

Skipped Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt [260-260]

    maintainability: "Inconsistent method name for token list retrieval"

  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [266-266]

    best practice: "Magic number in dust token filtering logic"

@jaymengxy jaymengxy merged commit 0374a7d into develop May 13, 2025
3 checks passed
@jaymengxy jaymengxy deleted the verified_token branch May 13, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Verifiy token feature remain issues

2 participants