Conversation
fix: manage display token filter issues
fix: post staking info
fix: remove the unnecessary reports
PR SummaryEnhanced token management functionality by improving verified token filtering and adding dust token hiding capabilities. Updated token list management to properly handle verified/unverified tokens and dust tokens (< $0.01 USD). Added informational UI elements and improved error handling across the application. Changes
autogenerated by presubmit.ai |
lealobanov
approved these changes
May 14, 2025
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (6)
fix: remove the unnecessary reports
- 1aa6f3c: fix: remove the unnecessary reports
- 967b470: Merge pull request #1047 from onflow/fix_staking_info
fix: post staking info
fix: manage display token filter issues
- 8cea364: fix: manage display token filter issues
Files Processed (19)
- app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/childaccount/ChildAccountList.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/flow/FlowCadenceApi.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/browser/Utils.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/manage/presenter/ManageTokenPresenter.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/wallet/WalletFragmentViewModel.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/utils/Log.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/utils/error/Error.kt (1 hunk)
- app/src/main/res/drawable/ic_question.xml (1 hunk)
- app/src/main/res/layout/activity_manage_token.xml (3 hunks)
- app/src/main/res/layout/dialog_hide_dust_token_tip.xml (1 hunk)
- app/src/main/res/layout/dialog_select_token.xml (2 hunks)
- app/src/main/res/values/strings.xml (2 hunks)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt [260-260]
performance: "Potential UI thread blocking operation"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/manager/flow/FlowCadenceApi.kt [55-55]
maintainability: "Error message information is lost in exception handling"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [237-237]
best practice: "Magic number used in business logic"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)