Skip to content

Merge verified/unverified token fixes to master#1052

Merged
jaymengxy merged 6 commits intomasterfrom
develop
May 14, 2025
Merged

Merge verified/unverified token fixes to master#1052
jaymengxy merged 6 commits intomasterfrom
develop

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #???

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy requested a review from a team as a code owner May 14, 2025 00:26
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2025

PR Summary

Enhanced token management functionality by improving verified token filtering and adding dust token hiding capabilities. Updated token list management to properly handle verified/unverified tokens and dust tokens (< $0.01 USD). Added informational UI elements and improved error handling across the application.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt Changed block list update log level from error to debug for better log clarity
app/src/main/java/com/flowfoundation/wallet/manager/childaccount/ChildAccountList.kt Modified cache file name from child_account_list to child_accounts and removed unused import
app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt Removed redundant error reporting calls for EVM address retrieval failures
app/src/main/java/com/flowfoundation/wallet/manager/flow/FlowCadenceApi.kt Simplified Flow exception message by directly passing the throwable
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt Fixed verified and dust token filtering by preserving display list snapshot before applying filters
app/src/main/java/com/flowfoundation/wallet/page/browser/Utils.kt Changed favicon service from custom CDN to DuckDuckGo's icon service
app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt Added persistent verified token filter state and improved token list filtering logic
app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt Changed default state of verified token switch to checked
app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt Removed forced provider refresh and updated token list retrieval method
app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt New dialog component to explain dust token filtering (tokens < $0.01 USD)
app/src/main/java/com/flowfoundation/wallet/page/token/manage/presenter/ManageTokenPresenter.kt Added click handler to show dust token tip dialog
app/src/main/java/com/flowfoundation/wallet/page/wallet/WalletFragmentViewModel.kt Changed direct value assignment to postValue for thread safety
app/src/main/java/com/flowfoundation/wallet/utils/Log.kt Added cause information to exception logging
app/src/main/java/com/flowfoundation/wallet/utils/error/Error.kt Removed redundant GET_ADDRESS_FAILED error enum
app/src/main/res/drawable/ic_question.xml New question mark icon for help tooltips
app/src/main/res/layout/activity_manage_token.xml Added help icon and improved layout constraints for token management screen
app/src/main/res/layout/dialog_hide_dust_token_tip.xml New dialog layout explaining dust token filtering feature
app/src/main/res/layout/dialog_select_token.xml Added bottom padding and removed redundant padding declaration
app/src/main/res/values/strings.xml Simplified dust token label and added tip string resource

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (6)

fix: remove the unnecessary reports

  • 1aa6f3c: fix: remove the unnecessary reports
  • 967b470: Merge pull request #1047 from onflow/fix_staking_info

fix: post staking info

fix: manage display token filter issues

  • 8cea364: fix: manage display token filter issues
Files Processed (19)
  • app/src/main/java/com/flowfoundation/wallet/manager/blocklist/BlockManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/childaccount/ChildAccountList.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/evm/EVMWalletManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/manager/flow/FlowCadenceApi.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/browser/Utils.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/presenter/AddTokenPresenter.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt (2 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/token/manage/HideDustTokenTipDialog.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/page/token/manage/presenter/ManageTokenPresenter.kt (3 hunks)
  • app/src/main/java/com/flowfoundation/wallet/page/wallet/WalletFragmentViewModel.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/utils/Log.kt (1 hunk)
  • app/src/main/java/com/flowfoundation/wallet/utils/error/Error.kt (1 hunk)
  • app/src/main/res/drawable/ic_question.xml (1 hunk)
  • app/src/main/res/layout/activity_manage_token.xml (3 hunks)
  • app/src/main/res/layout/dialog_hide_dust_token_tip.xml (1 hunk)
  • app/src/main/res/layout/dialog_select_token.xml (2 hunks)
  • app/src/main/res/values/strings.xml (2 hunks)
Actionable Comments (1)
  • app/src/main/java/com/flowfoundation/wallet/page/token/detail/widget/MoveTokenDialog.kt [260-260]

    performance: "Potential UI thread blocking operation"

Skipped Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/manager/flow/FlowCadenceApi.kt [55-55]

    maintainability: "Error message information is lost in exception handling"

  • app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [237-237]

    best practice: "Magic number used in business logic"

@jaymengxy jaymengxy merged commit 7e54aa8 into master May 14, 2025
5 checks passed
@github-actions github-actions Bot mentioned this pull request May 28, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants