Skip to content

feat: move nft evm address check#1064

Merged
lmcmz merged 1 commit intodevelopfrom
move_nft_check
May 14, 2025
Merged

feat: move nft evm address check#1064
lmcmz merged 1 commit intodevelopfrom
move_nft_check

Conversation

@jaymengxy
Copy link
Copy Markdown
Contributor

Related Issue

Closes #???

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@jaymengxy jaymengxy requested a review from a team as a code owner May 14, 2025 15:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2025

PR Summary

Removed conditional canBridgeToEVM() checks and simplified the NFT movement logic for EVM addresses. The changes streamline the process of moving NFTs between addresses by removing redundant checks and assuming EVM compatibility by default.

Changes

File Summary
app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt Removed canBridgeToEVM() conditional checks throughout the file. Modified address list handling to always include EVM addresses. Simplified NFT movement logic by removing redundant EVM bridge checks and assuming EVM compatibility by default.

autogenerated by presubmit.ai

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • 78f260c: feat: move nft evm address check
Files Processed (1)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt (4 hunks)
Actionable Comments (2)
  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [119-122]

    possible issue: "Missing fallback handling for empty address list"

  • app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [215-215]

    possible bug: "Potential unhandled edge case in address validation"

Skipped Comments (0)

@lmcmz lmcmz merged commit 29accef into develop May 14, 2025
3 checks passed
@lmcmz lmcmz deleted the move_nft_check branch May 14, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants