Conversation
Fix token security info
feat: move nft evm address check
PR SummaryEnhanced the NFT bridge functionality by simplifying EVM address checks and improved token security information display. Removed conditional EVM bridge checks and updated token contract verification links to support both Flow and EVM tokens. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (5)
feat: move nft evm address check
- 78f260c: feat: move nft evm address check
- 03f0569: Merge pull request #1060 from onflow/fix_token_security_info
Fix token security info
Files Processed (2)
- app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/token/detail/presenter/TokenDetailPresenter.kt (2 hunks)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [95-96]
possible issue: "Potential unhandled null case in address list modification"
-
app/src/main/java/com/flowfoundation/wallet/page/nft/move/MoveNFTDialog.kt [119-122]
possible bug: "Potential null reference when handling EVM address"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/token/detail/presenter/TokenDetailPresenter.kt [138-143]
best practice: "Missing error handling for browser navigation"
lmcmz
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)