Conversation
* Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * Hot fix - telegram deep linking * WC deep linking * WC deep linking
fix: update the version code
* Debug crash in WebView dropdown * Bump CrowdIn to latest * Bump CrowdIn to latest * Bump CrowdIn to latest * Bump CrowdIn to latest * Bump CrowdIn to latest
Additional WC debugging
Deep linking refactoring
fix: nft collection external url
fix: validate pairing uri
fix: walletconnect clean up session
PR SummaryImproved deep linking architecture with new URI handling system, enhanced WalletConnect integration, and various UI improvements. Added support for Telegram deep links and improved session management. Updated Crowdin SDK and version code to r2.8.6. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (30)
fix: update the version code
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
Hot fix - telegram deep linking
-
WC deep linking
-
WC deep linking
- 8cfabd7: WC deep linking
- 1636e84: WC deep linking
- a69552b: Hot fix - telegram deep linking
- a29c063: Hot fix - telegram deep linking
- 3a3501f: Hot fix - telegram deep linking
- dbf897f: Hot fix - telegram deep linking
- 7a2ab7e: Hot fix - telegram deep linking
- aa21958: Hot fix - telegram deep linking
- 2e30fb0: Debugging
- 15ef59e: Debugging
- 615b7db: Debugging
- 6042104: Debugging
- ea9539d: Debugging
- fb65831: Debugging
- 6f1a7b8: Merge remote-tracking branch 'origin/wc-debugging-2' into wc-debugging-2
- cbbcbeb: Disable dev build on branch
- 0b8d5cf: Merge branch 'develop' into wc-debugging-2
- a025e70: Improve session cleanup
- dcad73d: Improve session cleanup
- f1ae541: Improve session cleanup
- a7817ac: Improve session cleanup
- 1fc7469: Improve session cleanup
- 84e630e: Run build
- 57a5d7a: Session cleanup
- 81900f6: Session cleanup
- b908eb4: Improve error handling
- c1df5b3: Improve error handling
Files Processed (25)
- app/build.gradle (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/FlowWalletApplication.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/crowdin/CrowdinUtils.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/config/NftCollectionConfig.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/walletconnect/Utils.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/walletconnect/WalletConnect.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/manager/walletconnect/WalletConnectDelegate.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/address/presenter/AddressBookPersonPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/browser/widgets/LilicoWebView.kt (11 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/collection/presenter/CollectionContentPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkType.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/DeepLinkingActivity.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/PendingActionHelper.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/UriHandler.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/Utils.kt (4 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/profile/presenter/ProfileFragmentPresenter.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/profile/subpage/wallet/key/presenter/AccountKeyListItemPresenter.kt (3 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/wallet/sync/WalletSyncViewModel.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/widgets/webview/evm/dialog/EVMSendTransactionDialog.kt (1 hunk)
- app/src/main/res/layout/activity_add_address.xml (1 hunk)
- app/src/main/res/layout/dialog_evm_transaction.xml (2 hunks)
- app/src/main/res/layout/layout_key_list_item.xml (1 hunk)
- app/src/main/res/values/strings.xml (3 hunks)
- gradle.properties (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/page/component/deeplinking/UriHandler.kt [85-87]
possible issue: "Potential loss of WalletConnect connection attempts"
Skipped Comments (3)
-
app/src/main/java/com/flowfoundation/wallet/manager/walletconnect/WalletConnectDelegate.kt [446-449]
enhancement: "Improve error handling for stale WalletConnect sessions"
-
app/src/main/java/com/flowfoundation/wallet/page/profile/presenter/ProfileFragmentPresenter.kt [156-156]
performance: "Fragment lifecycle check could be optimized"
-
app/src/main/java/com/flowfoundation/wallet/widgets/webview/JsInterface.kt [54-58]
possible bug: "Color parsing could be more robust"
Comment on lines
+85
to
+87
| // Save for later processing or initialize | ||
| // PendingActionHelper.savePendingDeepLink(context, Uri.parse(wcUri)) | ||
| false |
There was a problem hiding this comment.
When WalletConnect is not initialized, the handler returns false without saving the URI for later processing. This could lead to lost connection attempts. Consider implementing the commented-out PendingActionHelper.savePendingDeepLink() call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)