Conversation
PR SummaryEnhanced the Firebase authentication process by implementing forced JWT token refresh after custom token sign-in. This change ensures a fresh ID token is obtained immediately after authentication, improving token validity and session management. The update also includes a version code bump from 297 to 298. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- ff603b2: fix: login jwt force refresh
Files Processed (2)
- app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt (1 hunk)
- gradle.properties (1 hunk)
Actionable Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [53-53]
possible bug: "Redundant callback invocation could lead to duplicate responses"
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [40-40]
security: "Sensitive information logged"
Skipped Comments (0)
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (1)
- 94eb4ec: fix: login jwt force refresh
Files Processed (2)
- app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt (1 hunk)
- gradle.properties (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [38-47]
possible issue: "Potential memory leak in Firebase token listener"
Skipped Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [44-44]
possible issue: "Firebase messaging token fetched after callback completion"
lmcmz
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1162
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)