Conversation
fix: display the added new token
* NFT list * NFT list * NFT list
fix: login jwt force refresh
PR SummaryEnhanced Firebase authentication by implementing forced JWT token refresh, improved NFT list view functionality with grid/list toggle support, and optimized token management for better display of newly added tokens. Also includes version bump to 298. Changes
autogenerated by presubmit.ai |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🚨 Pull request needs attention.
Review Summary
Commits Considered (6)
fix: login jwt force refresh
-
NFT list
-
NFT list
-
NFT list
fix: display the added new token
- 0eea9bc: fix: display the added new token
Files Processed (6)
- app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/nft/nftlist/NftViewModel.kt (2 hunks)
- app/src/main/java/com/flowfoundation/wallet/page/nft/nftlist/presenter/NFTFragmentPresenter.kt (1 hunk)
- app/src/main/java/com/flowfoundation/wallet/page/token/addtoken/AddTokenViewModel.kt (1 hunk)
- gradle.properties (1 hunk)
Actionable Comments (1)
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [40-40]
security: "Security concern with logging sensitive authentication token"
Skipped Comments (2)
-
app/src/main/java/com/flowfoundation/wallet/firebase/auth/FirebaseAuth.kt [38-47]
possible issue: "Potential memory leak in async callback chain"
-
app/src/main/java/com/flowfoundation/wallet/manager/token/FungibleTokenListManager.kt [192-199]
enhancement: "Simplify nested null checks"
| if (task.isSuccessful) { | ||
| auth.currentUser?.getIdToken(true)?.addOnSuccessListener { result -> | ||
| val jwt = result.token | ||
| logd(TAG, "get token finish, token:${jwt}") |
There was a problem hiding this comment.
Avoid logging sensitive information like JWT tokens, even in debug logs. This could lead to token exposure if logs are captured. Consider logging only non-sensitive metadata or removing the token from the log message.
lmcmz
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #???
Summary of Changes
Need Regression Testing
Risk Assessment
Additional Notes
Screenshots (if applicable)