Add TidalProtocolUtils contract containing math utils & initial test#22
Merged
sisyphusSmiling merged 1 commit intotracer-bulletfrom Jul 15, 2025
Merged
Add TidalProtocolUtils contract containing math utils & initial test#22sisyphusSmiling merged 1 commit intotracer-bulletfrom
sisyphusSmiling merged 1 commit intotracer-bulletfrom
Conversation
sisyphusSmiling
requested review from
Kay-Zee,
bthaile,
joshuahannan,
kgrgpg and
nialexsan
sisyphusSmiling
force-pushed
the
gio/add-uint-lib
branch
from
44f0fe1 to
83cd1d6
Compare
joshuahannan
approved these changes
Jul 11, 2025
Contributor
joshuahannan
left a comment
joshuahannan
left a comment
There was a problem hiding this comment.
why not just use the ones that are already deployed for the bridge?
Contributor
Author
|
@joshuahannan initially, I was hoping to avoid adding new dependencies to simplify developing on the hosted emulator environment. But as we continued in #25, we ended up including quite a few more TidalProtocol-specific methods. IMO omitting the vm bridge utils & its dependencies simplifies dev-ex around TidalProtocol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The contents of this PR are ported from FlowEVMBridgeUtils including the new TidalProtocolUtils as well as conversion tests. These are included in anticipation of subsequent changes addressing insufficient decimal precision served by UFix64 in the TidalProtocol contract.