Merged
Conversation
added 8 commits
July 9, 2025 17:08
…low (#26) - Changed interestMul division from e8 to 10^9 to match 18-decimal indices - Fixed missing division by targetHealth in fundsRequiredForTargetHealthAfterWithdrawing - Added underflow protection when subtracting debt values
Contributor
Author
|
Point of discussion: what thoughts do we have about updating health to increase decimal precision? I think it's relevant as it's a key metric related to available & required amounts, but maybe we do so in a followup PR. |
nialexsan
approved these changes
Jul 15, 2025
This was referenced Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description