ECDSA minor refactor#25
Merged
Merged
Conversation
Kay-Zee
reviewed
Mar 26, 2025
| alg: a, | ||
| goPrKey: sk, | ||
| pubKey: nil, // public key is not computed | ||
| pubKey: nil, // public key is not constructed |
Member
There was a problem hiding this comment.
Now that we do the computation right away, does defering construction still bring some amount of benefit?
Collaborator
Author
There was a problem hiding this comment.
The benefit is negligible, it only saves the extra structure allocation.
The real reason is that I wanted this PR to make minimal changes till I work on supporting 1.24. There will be more internal changes at that time (to also remove the usage of deprecated functions) and I don't exclude getting back to the status where the public key computation isn't needed (non FIPS 140-3).
Kay-Zee
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ECDSA minor refactor preparing for Go 1.24 support