Enable non cgo build#8
Merged
Merged
Conversation
76b8422 to
1354295
Compare
Member
|
Don't know, but wanted to flag: The build is green, but a GH action is flagging issues at the bottom of the PR: https://github.com/onflow/crypto/pull/8/files#file-sign-go-L77 |
Collaborator
Author
Good flag. This is because of a new check I added to CI in 65daa31. The test checks that the build with incorrect flags fail. The errors are expected but I would prefer that they don't show in every PR 🤔 |
added 2 commits
April 2, 2024 16:15
bb3ee7a to
9c0feda
Compare
Collaborator
Author
|
re displayed errors while CI pass : errors are not displayed anymore by disabling the go matcher in the workflow 9c0feda |
added 2 commits
April 3, 2024 11:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, cgo is required to build the module.
However:
This PR solves both issues above:
CGO_ENABLED=0and using the build tagno_cgo.Changes to CI jobs:
no-cgotag)