Skip to content

Update Stable Cadence feature branch to Cadence v1.0.0-M4#1366

Merged
turbolent merged 8 commits into
feature/stable-cadencefrom
bastian/update-cadence
Jan 31, 2024
Merged

Update Stable Cadence feature branch to Cadence v1.0.0-M4#1366
turbolent merged 8 commits into
feature/stable-cadencefrom
bastian/update-cadence

Conversation

@turbolent

Copy link
Copy Markdown
Member

For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Jan 30, 2024
@turbolent turbolent requested a review from a team January 30, 2024 21:07
@turbolent turbolent self-assigned this Jan 30, 2024
@turbolent turbolent added dependencies Pull requests that update a dependency file and removed Improvement Technical work without new features, refactoring, improving tests labels Jan 30, 2024
@turbolent turbolent marked this pull request as draft January 30, 2024 21:13
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (f5ab0f6) 40.74% compared to head (679b299) 36.25%.
Report is 57 commits behind head on feature/stable-cadence.

Files Patch % Lines
internal/accounts/fund.go 0.00% 15 Missing ⚠️
internal/accounts/create-interactive.go 0.00% 12 Missing ⚠️
internal/super/flix.go 43.75% 9 Missing ⚠️
internal/accounts/accounts.go 11.11% 7 Missing and 1 partial ⚠️
internal/accounts/create.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1366      +/-   ##
==========================================================
- Coverage                   40.74%   36.25%   -4.50%     
==========================================================
  Files                          39       43       +4     
  Lines                        2118     2419     +301     
==========================================================
+ Hits                          863      877      +14     
- Misses                       1160     1446     +286     
- Partials                       95       96       +1     
Flag Coverage Δ
unittests 36.25% <27.69%> (-4.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent

Copy link
Copy Markdown
Member Author

Except for disabling a test that requires WIP code in 679b299, this PR should be good to go now

@turbolent turbolent requested a review from tarakby January 31, 2024 20:21
@turbolent turbolent marked this pull request as ready for review January 31, 2024 20:21
Comment on lines +41 to +42
// TODO:
t.Skip("TODO")

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to eventually re-enable this test when we'll merge the Cadence 1.0 feature branch into master, but at the moment this test relies on the core contracts, which aren't fully updated yet

@tarakby tarakby left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the go.mod files and left a comment below.

Comment thread go.mod
@turbolent turbolent merged commit 2f21924 into feature/stable-cadence Jan 31, 2024
@turbolent turbolent deleted the bastian/update-cadence branch January 31, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants