Skip to content

[Stable Cadence] Fix dependency: use proper version of core contracts#1369

Merged
turbolent merged 2 commits into
feature/stable-cadencefrom
bastian/fix-core-contract-templates
Feb 1, 2024
Merged

[Stable Cadence] Fix dependency: use proper version of core contracts#1369
turbolent merged 2 commits into
feature/stable-cadencefrom
bastian/fix-core-contract-templates

Conversation

@turbolent

@turbolent turbolent commented Feb 1, 2024

Copy link
Copy Markdown
Member

Resolve the remaining problem encountered in #1366: Use the correct core contract templates, which were not automatically picked by Go because the core contracts repo was mistagged at some point.

@codecov-commenter

codecov-commenter commented Feb 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 149 lines in your changes are missing coverage. Please review.

Comparison is base (f5ab0f6) 40.74% compared to head (bb3e601) 40.49%.
Report is 174 commits behind head on feature/stable-cadence.

Files Patch % Lines
internal/dependencymanager/dependencyinstaller.go 45.39% 57 Missing and 20 partials ⚠️
internal/accounts/fund.go 0.00% 15 Missing ⚠️
internal/dependencymanager/add.go 0.00% 14 Missing ⚠️
internal/accounts/create-interactive.go 0.00% 12 Missing ⚠️
internal/dependencymanager/install.go 0.00% 11 Missing ⚠️
internal/super/flix.go 43.75% 9 Missing ⚠️
internal/accounts/accounts.go 11.11% 7 Missing and 1 partial ⚠️
internal/accounts/create.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/stable-cadence    #1369      +/-   ##
==========================================================
- Coverage                   40.74%   40.49%   -0.26%     
==========================================================
  Files                          39       47       +8     
  Lines                        2118     2588     +470     
==========================================================
+ Hits                          863     1048     +185     
- Misses                       1160     1416     +256     
- Partials                       95      124      +29     
Flag Coverage Δ
unittests 40.49% <36.86%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@turbolent turbolent merged commit 64f7944 into feature/stable-cadence Feb 1, 2024
@turbolent turbolent deleted the bastian/fix-core-contract-templates branch February 1, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants