Conversation
Nithishvb
pushed a commit
to Nithishvb/onlook
that referenced
this pull request
May 11, 2025
* add color picker * refactor update styles function * fix(style): display padding when first clicking on element * remove log * feat(editor): add image manager * feat(editor) add text editor * fix click styles (onlook-dev#23)
Kitenite
added a commit
that referenced
this pull request
May 28, 2025
t1c1
pushed a commit
to t1c1/onlookbotcodes
that referenced
this pull request
Jun 5, 2025
* Update roadmap * Opening code block in vscode
epinnock
added a commit
to epinnock/onlook
that referenced
this pull request
Apr 23, 2026
…ke unblocked
Xcode 16.4 on mini unblocked the iOS simulator smoke test that the ADR
listed as gated on Xcode 16.1. Screenshots post-g-{hello,updated}.png
and the log trail in commit 1c58d3a are the evidence.
Native C++ wiring (onlook-dev#23–25 — OnlookRuntimeInstaller::install / cpp
mountOverlay / cpp reloadBundle) remains separate work — the JS-
fallback runtime path exercises the full ABI v1 contract today and the
committed code doesn't depend on the native host-function path.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
epinnock
added a commit
to epinnock/onlook
that referenced
this pull request
Apr 23, 2026
…solved Two stale notes in the Known Remaining Implementation Gates section: 1. QB-18 incremental rebuild — already shipped. __tests__/incremental.test.ts ships 8 passing tests (cache-hit re-emit, invalidated-on-edit, stale-source gating). Note updated from "still needs" to "landed". 2. Waves D/E/G/F "gated on Xcode 16.1 blocker" — the Mac mini's Xcode 16.4 unblocked onlook-dev#97 on 2026-04-23; the full iOS simulator smoke test passed end-to-end against REAL committed code (screenshots in plans/adr/assets/v2-pipeline/post-g-*.png). Native C++ wiring (onlook-dev#23-25) remains as separate optimization — the JS-fallback already covers the ABI contract on-device. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
epinnock
added a commit
to epinnock/onlook
that referenced
this pull request
Apr 23, 2026
After the user requested concrete scoping on the two blocked items, Explore agent audit + code inspection found: - **Task A unblocked**: sessionId source was the only open design question. Answer: extract from `/status` body's `manifestUrl`. Shipped `parseManifestUrl()` (5ab9a70) so the React hook layer doesn't re-implement URL parsing. Remaining work is pure React lifecycle + render-surface choice. - **Task B likely done**: Queue onlook-dev#23-onlook-dev#25 status is stale. All .cpp files present + registered in pbxproj, install() called from index.js, mountOverlay wired inline. Operator validation on the Mac mini (Xcode 16.4, already unblocked) is the only remaining step before flipping onlook-dev#23-onlook-dev#25 to done. Session log captures both findings with commit + file-path pointers so the next operator / session has a precise starting point. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
epinnock
added a commit
to epinnock/onlook
that referenced
this pull request
Apr 23, 2026
Photographic evidence for Task B native C++ JSI registration
working end-to-end on the Mac mini (Xcode 16.4, iPhone 16 Pro sim,
iOS 18.6). Captured via xcrun simctl io screenshot after the native
app boot completed with these log lines:
[onlook-runtime] hermes ready
composed combined bundle (1358487 bytes) at
/tmp/onlook-combined.jsbundle
[onlook-runtime] Fabric tap bridge registration requested
[onlook-runtime] Fabric tap bridge attached to root view (attempt 1)
[onlook-runtime-direct] installHostObject entered
[onlook-runtime-direct] nativeLoggingHook installer completed
That log trace confirms:
1. OnlookRuntimeInstaller.cpp::install() executed at app launch
(via index.js:104-117 TurboModuleRegistry.get(...).install() call)
2. Hermes JSI runtime accepted the host-object installation
3. Native Fabric tap bridge attached for tap-to-source
4. nativeLoggingHook published onto globalThis
**This validates Phase 9 Task B end-to-end.** Queue rows onlook-dev#23–onlook-dev#25
flip partial → done. The Xcode 16.1 blocker referenced in the
task-queue notes is genuinely resolved.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
epinnock
added a commit
to epinnock/onlook
that referenced
this pull request
Apr 23, 2026
…d partial → done Phase 9 Task B validation complete. All three rows reference the 2026-04-23 Mac mini Xcode 16.4 + iOS 18.6 simulator session (via SSH to scry-farmer@192.168.0.17): onlook-dev#23 OnlookRuntimeInstaller: install() executes at launch, publishes host-object + nativeLoggingHook (log trace confirmed). onlook-dev#24 OnlookRuntime_runApplication.cpp: compiles + links clean on x86_64 + arm64, wired through get() → makeHostMethod() → runApplicationImpl(). onlook-dev#25 OnlookRuntime_reloadBundle.cpp: same — wired via reloadBundle() → reloadBundleImpl(). mountOverlay inline. Evidence: `plans/adr/assets/v2-pipeline/post-h-native-sim.png` (commit 2cdd2c0) captures the native Onlook launcher rendered on iPhone 16 Pro sim. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What is the purpose of this pull request?