Replace PNG icons with SVG for future Redmine compatibility #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redmine switched to SVG icons in version 6.0. This change updates the plugin icons accordingly while keeping PNG support for older Redmine versions.
|
Thank you for the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background / Purpose
Redmine switched to SVG icons in version 6.0.
Although PNG icons and related CSS styles have been kept for backward compatibility with plugins and themes in version 6.1, they might be removed in the future. Therefore, I think it would be better to migrate to SVG icons in the near future.
In fact, support for PNG icons was removed in trunk with r24029.
While it’s unclear whether this change will remain in Redmine 7.0, PNG icon support might be removed in the near future.
Details
This pull request replaces PNG icons used in this plugin with SVG icons.
Screenshots
Redmine 5.1
Details
Redmine 6.0
Details
Redmnine 6.1
Details
trunk (r24062)
Details