Remove unnecessary icon styles #129
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These icon styles do not need to be defined in the plugin because identical styles are already defined in Redmine itself, at least up to version 6.1. Defining them globally in the plugin could even cause unexpected UI issues. Removing these styles still allows icons (PNG or SVG) to display correctly from Redmine 5.1 through trunk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background / Purpose
This PR removes the following icon style added in #128, which turned out to be actually unnecessary:
redmine-view-customize/assets/stylesheets/view_customize.css
Lines 73 to 78 in dfee75d
Details
Up to Redmine 6.1, the same style has already been defined in Redmine core, so there is no need for this plugin to define the
.iconstyle.Keeping this style globally in the plugin might even cause unexpected UI issues in the future.
Checks
Confirmed that icons are displayed correctly from Redmine 5.1 through trunk (r24062).
5.1
Details
6.0
Details
trunk(r24062)
Details