Create cml1.yaml#1
Open
onsSK wants to merge 1 commit into
Open
Conversation
Reviewer's Guide by SourceryThis pull request adds a new GitHub Actions workflow file named 'cml1.yaml' to set up a basic MLOps pipeline using Continuous Machine Learning (CML). The workflow is triggered on every push and runs on the latest Ubuntu environment. File-Level Changes
Tips
|
There was a problem hiding this comment.
Hey @onsSK - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider replacing the Jupyter notebook (stage.ipynb) with a plain Python script for better version control and reproducibility in the CI/CD pipeline.
- It's recommended to pin the Ubuntu runner to a specific version (e.g., ubuntu-20.04) to ensure consistency across workflow runs.
- Review the commented-out Node.js and Python setup steps. If these are needed, consider including them explicitly to ensure the correct versions are used.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -0,0 +1,23 @@ | |||
| name: mlops | |||
| on: [push] | |||
There was a problem hiding this comment.
suggestion (performance): Consider more specific trigger conditions
Triggering the workflow on every push might be inefficient, especially if the ML workflow is computationally intensive. Consider using more specific conditions, such as pushes to certain branches or changes to specific files.
on:
push:
branches:
- main
- develop
paths:
- 'src/**'
- 'models/**'
- 'data/**'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Introduce a new GitHub Actions workflow to automate machine learning operations by adding a 'cml1.yaml' file.
CI: