Having trouble with malformed arguments in >= v2.23.1

[sebrandon1]

I'm attempting to update my ginkgo version to v2.23.3 and I'm receiving issues with my following script one liner:

https://github.com/redhat-best-practices-for-k8s/certsuite-qe/blob/main/scripts/run-tests.sh#L61

ginkgo -timeout=24h -v ${PFLAG} ${FFLAG} --keep-going "${GINKGO_SEED_FLAG}" --output-interceptor-mode=none --require-suite $command

It's telling me (example here):

ginkgo run failed
    Malformed arguments - detected a flag after the package liste
      Make sure all flags appear after the Ginkgo subcommand and before your list of
      packages (or './...').
      e.g. 'ginkgo run -p my_package' is valid but `ginkgo -p run my_package` is
      not.
      e.g. 'ginkgo -p -vet ./...' is valid but 'ginkgo -p ./... -vet' is not

I noticed the release v2.23.1 has mentioned that if anyone hits a problem to create an issue. I've tried various configurations of my command it's still having a problem with malformed arguments.

Can someone help me fix my command?

Thanks!

[sebrandon1]

As a suggestion, maybe if there is a malformed flag could it be pointed out in the error message? That could help with debugging which is malformed.

[onsi]

hey there - yes i can try to make the error message both clearer and a bit more helpful.

the issue is that any flags that appear after a non-flag argument were getting silently ignored. I've followed your link to the failing CI build but wasn't able to see the precise ginkgo invocation that led to this failure. Do you have that? (ie with the $VARIABLES interpolated)

[sebrandon1]

Good point, I printed out the command in another run:

ginkgo -v --procs=16 --flake-attempts=2 --keep-going  --output-interceptor-mode=none --timeout=24h --require-suite  tests/observability

[sebrandon1]

Interesting, when I wrap the ginkgo command in a $(command) call in bash, it works! Example run here

This runs to completion however I don't get the "live" output from ginkgo as it is being stored into $RESULT.

[sebrandon1]

Okay so I think I figured out what was happening, my $command which is supposed to be tests/observability must have had some spaces wrapping it on either side. I added command=$(echo $command | xargs) to remove the spacing around my command and ginkgo is happy with it now.

[onsi]

hey @sebrandon1 - glad this got figured out, though it does seem kinda odd that spaces would be an issue. I'm going to close this for now but feel free to reopen it if you'd like.