Skip to content

refactor(workbench): simplify node inspector - #2

Merged
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:happy-hare
Aug 25, 2026
Merged

refactor(workbench): simplify node inspector#2
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:happy-hare

Conversation

@l1shen

@l1shen l1shen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 206faec6-f664-4663-ac75-0fb56b5377aa

📥 Commits

Reviewing files that changed from the base of the PR and between 3077661 and 18f1195.

📒 Files selected for processing (10)
  • packages/open-flow/src/designer/browser/graph/ReactFlowContainer/ReactFlowContainer.module.scss
  • packages/open-flow/src/workbench/browser/runtime/designer/nodeInspector.test.tsx
  • packages/open-flow/src/workbench/browser/runtime/designer/nodeInspector.tsx
  • packages/open-flow/src/workbench/browser/runtime/designer/projectChanges.ts
  • packages/open-flow/src/workbench/browser/runtime/locales/en.json
  • packages/open-flow/src/workbench/browser/runtime/locales/zh-CN.json
  • packages/open-flow/src/workbench/browser/runtime/projectChanges.test.ts
  • packages/open-flow/src/workbench/browser/runtime/styles/context-panel.css
  • packages/open-flow/src/workbench/browser/runtime/styles/responsive.css
  • packages/open-flow/test/workbench-ui-style-boundaries.test.ts

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Summary by CodeRabbit

  • New Features

    • Simplified task inspection by focusing editing on task name, type, and execution settings.
    • Task input and output ports are now shown as read-only references.
    • Port changes are preserved when updating code, connector, or LLM tasks.
  • Style

    • Improved inspector spacing, disclosure controls, focus states, and responsive behavior.
    • Refined context menus and quick-pick popovers for more consistent sizing and layout.
    • Reduced-motion settings now apply to inspector transitions.

Walkthrough

The inspector no longer edits task ports or condition definitions as JSON. Task ports remain in task definitions, and task updates preserve them unless Code Task ports are changed explicitly. Connector ports display as read-only data. Tests cover node types, task updates, and style boundaries. Inspector, popup, localization, spacing, focus, and reduced-motion styles were updated.

Merge Risk: ⚪ Minimal · up to 18f11

This refactor is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so its relevance to the changeset cannot be assessed. Add a concise description covering the node inspector simplification, task port handling changes, and related styling and test updates.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title uses the required format type(scope): subject, uses English, and accurately describes the node inspector refactor.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@l1shen
l1shen merged commit 7dacb77 into oomol-lab:main Aug 25, 2026
8 checks passed
@l1shen
l1shen deleted the happy-hare branch August 25, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant