Skip to content

fix(designer): avoid remount update loop - #22

Merged
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:fix/designer-remount-loop
Aug 28, 2026
Merged

fix(designer): avoid remount update loop#22
l1shen merged 1 commit into
oomol-lab:mainfrom
l1shen:fix/designer-remount-loop

Conversation

@l1shen

@l1shen l1shen commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Summary\n- avoid republishing unchanged Variable projections during designer reconciliation\n- prevent the Runs-to-Design remount path from synchronously notifying external-store subscribers during commit\n- bump the published packages to 0.1.0-alpha.16\n\n## Verification\n- bun run check\n- bun run test\n- bun run build\n- bun run test:package

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 412cdafe-6f96-41b5-87dc-a6d30405fb97

📥 Commits

Reviewing files that changed from the base of the PR and between b3dfaf1 and 4c2021e.

⛔ Files ignored due to path filters (1)
  • bun.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • packages/command/package.json
  • packages/open-flow/package.json
  • packages/open-flow/src/designer/browser/graph/FlowDesigner/FlowDesignerView.test.tsx
  • packages/open-flow/src/designer/browser/graph/FlowDesigner/FlowDesignerView.tsx

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


Summary by CodeRabbit

  • Bug Fixes

    • Improved Flow Designer remount behavior to preserve existing variable inputs and names when the underlying model is unchanged.
    • Reduced unnecessary state updates, helping maintain stable designer state and responsiveness.
  • Tests

    • Added regression coverage for preserving variable projections during remounts.
  • Chores

    • Updated package versions to 0.1.0-alpha.16.

Walkthrough

FlowDesignerView.#syncModel now compares incoming variable inputs, variable names, and loading state with current values before updating reactive state. A regression test verifies that unchanged variable projections retain referential identity after remounting. The command and open-flow package versions increase from 0.1.0-alpha.15 to 0.1.0-alpha.16.

Merge Risk: ⚪ Minimal · up to 4c202

This change prevents redundant designer updates and remount-time subscriber notifications while adding focused test coverage; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required <type>(<scope>): <subject> format, uses English, and accurately describes the remount update-loop fix.
Description check ✅ Passed The description directly explains the projection update-loop fix, package version bump, and verification commands.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands.

@l1shen
l1shen merged commit 394e541 into oomol-lab:main Aug 28, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant