Skip to content

fix(billing): portal usage popover - #283

Merged
hyrious merged 1 commit into
mainfrom
fix/billing-usage-popover-portal
Jul 28, 2026
Merged

fix(billing): portal usage popover#283
hyrious merged 1 commit into
mainfrom
fix/billing-usage-popover-portal

Conversation

@hyrious

@hyrious hyrious commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Render the plan and usage popover through the shared Radix Popover portal so the titlebar overflow boundary cannot clip it.
  • Delegate collision handling, outside-click dismissal, Escape handling, and focus restoration to the shared primitive.
  • Keep the panel responsive to narrow and short windows without relaxing titlebar layout constraints.

Verification

  • corepack pnpm run ts-check
  • corepack pnpm run lint
  • corepack pnpm run format
  • corepack pnpm test — 285 files, 2,139 tests
  • corepack pnpm run build
  • Runtime/UI verification completed or not applicable — manual visual check requested

Safety and Compatibility

  • Local BYOK and signed-in OOMOL modes were considered separately; this renderer-only positioning change does not alter either flow.
  • No credential was exposed to the renderer, logs, fixtures, screenshots, or committed files.
  • Agent tools, permissions, and system prompts remain aligned; they are unaffected.
  • Migration, packaging, endpoint, and update implications were considered; none are introduced.
  • Relevant documentation and tests were updated or are not applicable; the existing full suite passes.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f8fb82aa-8cb4-4c89-8b22-6ac786ff073c

📥 Commits

Reviewing files that changed from the base of the PR and between a0194e1 and 111c715.

📒 Files selected for processing (1)
  • src/components/app-shell/BillingUsagePopover.tsx

Summary by CodeRabbit

  • Bug Fixes
    • Improved the billing usage popover’s opening, closing, and focus behavior.
    • Added a built-in close control for more consistent interaction.
    • Preserved billing usage details, error handling, and navigation functionality.

Walkthrough

BillingUsagePopover now uses Radix UI Popover primitives with controlled open state and onOpenChange handling. The billing usage button is rendered through PopoverTrigger, while the existing usage content is placed inside PopoverContent. The header close button uses PopoverClose. Custom refs, pointer and keyboard handlers, and focus restoration logic were removed. Billing data handling and details navigation remain unchanged.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title follows the required type(scope): subject format and accurately describes the billing usage popover portal change.
Description check ✅ Passed The description matches the template with Summary, Verification, and Safety and Compatibility sections filled out.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/billing-usage-popover-portal

Comment @coderabbitai help to get the list of available commands.

@hyrious
hyrious merged commit 97b9663 into main Jul 28, 2026
1 of 2 checks passed
@hyrious
hyrious deleted the fix/billing-usage-popover-portal branch July 28, 2026 11:06
alwaysmavs added a commit that referenced this pull request Jul 28, 2026
## Summary

- revert PR #281 and remove the macOS command sandbox preview
- restore the previous direct-execution and Full Access confirmation
behavior
- preserve all unrelated changes already merged into `main`, including
PRs #283 and #284

## Reason

The sandbox rollout appears to make the product unusable. This isolates
the rollback so the remaining recent work can stay in place.

## Verification

- [x] `corepack pnpm run ts-check`
- [x] `corepack pnpm run lint`
- [x] `corepack pnpm run format`
- [x] `corepack pnpm test` (281 files, 2106 tests)
- [x] `corepack pnpm run build`

The reverted file set exactly matches all 43 files changed by PR #281,
with no missing or extra paths.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant