add bouncer/net-tests to ooniapi under new router bouncer #1036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LDiazN
reviewed
Nov 11, 2025
LDiazN
reviewed
Nov 11, 2025
Contributor
|
related to #807 |
I modified the tests to expect any error (other than http response 200) because FastAPI returns HTTP error 422 Unprocessable Entity instead of 400, as the tests do not supply a request that the model can validate
LDiazN
reviewed
Nov 17, 2025
| def test_bouncer_net_tests_bad_request1(client): | ||
| resp = client.post("/bouncer/net-tests") | ||
| # XXX: fastapi returns 422 Unprocessable Entity; expected result was 400 in old test | ||
| assert resp.status_code != 200 |
Contributor
There was a problem hiding this comment.
As a last thing, let's also change this to assert resp.status_code == 400 and add a comment to specify that it's for backward compatibility reasons
LDiazN
reviewed
Nov 17, 2025
| j = {"net-tests": []} | ||
| resp = client.post("/bouncer/net-tests", json=j) | ||
| # XXX: fastapi returns 422 Unprocessable Entity; expected result was 400 in old test | ||
| assert resp.status_code != 200 |
Contributor
There was a problem hiding this comment.
See previous comment: https://github.com/ooni/backend/pull/1036/files#r2533818398
Contributor
|
Hey nice work, thanks for putting this together! Let's fix the expected status code in the test and we're good to go |
LDiazN
added a commit
that referenced
this pull request
Dec 18, 2025
* in test_settings, add clickhouse_server fixture (#1028) * in test_settings, add clickhouse_server fixture * delay and decrease probe frequency of is_clickhouse_running to reduce logspam * remove docker_ip and docker_services included by clickhouse_server * add collectors to ooniapi (#1032) * add collectors to ooniapi * Make method "GET" on route for list_collectors * Use SettingsDep from ooniprobe.dependencies * add geolookup to ooniapi probe services (#1031) * add geolookup to ooniapi probe services this includes a small refactor to make the probe_geoip method re-usable * Replace class docstring with pydantic.Field annotation * use pydantic field validation for geolookup endpoint * probe_services: validate probe_geoip; add type GeoLookupResult * monkeypatch lookup_probe_cc and lookup_probe_network to provide static responses * add bouncer/net-tests to ooniapi under new router bouncer (#1036) * add bouncer/net-tests to ooniapi under new router bouncer * fix pylint import complaints * let fastapi validate input * exclude unset parameters in bouncer/net-tests * add bouncer tests from api/tests/integ/test_probe_services.py I modified the tests to expect any error (other than http response 200) because FastAPI returns HTTP error 422 Unprocessable Entity instead of 400, as the tests do not supply a request that the model can validate * raise HTTPException with status 400 for backwards-compatibility * check status code on error is 400 for backwards compatibility with old probes * Fix bad geoip reporting (#1022) * Add logging to failing comparision function * Trigger CI * Trigger CI * Fix bad db_asn logging * Improve logging of geoip mismatches * Fix extract_probe_ipaddr * Cusum changepoint api (#1027) * Add initial endpoint shape for event detector changepoints * Add cusum changepoint list endpoint * Remove unused request model * Add event detector changepoint * Fix event detector table migration for tests * Add basic test for changepoint endpoint * Add basic filtering test to changepoint endpoint * Remove unused log * Add tests to check filtering by date * Add utils module with useful types * Remove unused types * Remove unused import * Add enum for change direction * Black reformat * Add testing data from the DB * Remove out dated comment * Trigger ci * fix typo in changepoint api endpoint * trigger ci * Modify changepoints table to add block_type column * replace bad quotes * Add block_type field to changepoints API * Add prioritization CRUD methods (#1040) * Add prioritization CRUD methods /api/_/show_countries_prioritization /api/_/debug_prioritization * rename routers/prio to routers/prio_crud * use raw string in regex * S3 config parameter (#1039) * Add config bucket setting and function to read file from bucket * trigger ci --------- Co-authored-by: Luis Diaz <41093870+LDiazN@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.