Fix circular dependency in clickhouse proxy #235
Merged
Merged
Conversation
Ansible Run Output 🤖Ansible Playbook Recap 🔍Ansible playbook output 📖
|
| Pusher | @LDiazN |
| Action | pull_request |
| Working Directory | |
| Workflow | .github/workflows/check_ansible.yml |
| Last updated | Tue, 29 Apr 2025 08:51:56 GMT |
hellais
reviewed
Apr 11, 2025
hellais
reviewed
Apr 11, 2025
…eeding with the clickhouse proxy configuration
hellais
reviewed
Apr 28, 2025
hellais
reviewed
Apr 28, 2025
hellais
approved these changes
Apr 28, 2025
Member
hellais
left a comment
There was a problem hiding this comment.
I would add the comment mentioned in here and then it's good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff will fix some issues related to the clickhouse proxy deployment where sometimes you would get a dehydrated error when trying to deploy it, and the solution involved:
The error was caused because dehydrated and nginx weren't running in the correct order in the ansible play, and dehydrated required an nginx restart to work properly.
I fixed the order and added the nginx restart to the dehydrated role
closes #232
After applying this change, the
deploy-clickhouse-proxy.ymlplay should deploy the clickhouse proxy in one go without errors