Add support for ORG's blocked.org.uk scheduler#406
Conversation
dantheta
commented
Aug 31, 2015
|
Thanks a lot for this good work. I will review this PR in the upcoming days. |
|
Yes, that's right. The refactoring changes inside ooni/oonicli.py were quite substantial. |
|
Hi @dantheta, there is a merge conflict in |
Add support for ORG's blocked.org.uk scheduler
Add:
* ORG Queue integration
* Support for additional values to send to ORG backend
Refactor director startup
* Moved collector setup to shared scope
* Moved deck setup to shared scope
* Moved annotations setup to shared scope
* Moved global options to shared scope
* fix some naming convention errors
* move global counter to more sensible scope
* fixes from pull request code review
* remove another mobile browser
* remove iPhone useragent to prevent mobile versions being returned to client
* add HTTPS support for reporter
* add authentication info from environment
* import PROBE_ vars from environment into report
* allow https collector in regex
* AMQP connection details as cmdline parameter
* more queue state, looping listen call
* remove old bin script
* exit after bounded random number of test decks
* improve error handling
* use proper custom exception for queue timeout reason
* reduce duplicate serialization
* add flag to prevent response body being written to report
* add subargs to queue createdeck
* fix global args passing
* reuse cached geoip
* reuse existing TOR connection
* simplify for one-shot use
* extend and report lifetime
* probe exit on AMQP error
* remove ooniresource from setup script
dd6f194 to
6f437a0
Compare
|
That's done. Many thanks! |
|
Thanks! I'm now about at 75% of reading-the-diff-and-reasoning-about it. Next, I'll provide comments and start testing the code. |
There was a problem hiding this comment.
Note to self: the two functions above have been moved here without modifications from the old runWithDirector() code.
|
Have made progress with the review, added many comments, checked that the most substantial comments to #395 are also applied here. Still need to review the daemon director part and do testing. |