Skip to content

Update spec to include changes to the echcheck test#297

Merged
hellais merged 7 commits into
masterfrom
echcheck
Nov 20, 2024
Merged

Update spec to include changes to the echcheck test#297
hellais merged 7 commits into
masterfrom
echcheck

Conversation

@hellais

@hellais hellais commented Nov 7, 2024

Copy link
Copy Markdown
Member

Checklist

Description

Please, insert here a more detailed description.

Comment thread data-formats/df-006-tlshandshake.md Outdated
Comment thread data-formats/df-006-tlshandshake.md Outdated
Comment thread data-formats/df-006-tlshandshake.md Outdated
Comment thread nettests/ts-039-echcheck.md Outdated
Comment thread nettests/ts-039-echcheck.md Outdated
Comment thread nettests/ts-039-echcheck.md
Comment thread nettests/ts-039-echcheck.md
Comment thread nettests/ts-039-echcheck.md Outdated
DecFox pushed a commit to ooni/probe-cli that referenced this pull request Nov 20, 2024
)

## Checklist

- [x] I have read the [contribution
guidelines](https://github.com/ooni/probe-cli/blob/master/CONTRIBUTING.md)
- [x] reference issue for this pull request:
ooni/probe#1453
- [x] if you changed anything related to how experiments work and you
need to reflect these changes in the ooni/spec repository, please link
to the related ooni/spec pull request:
ooni/spec#297
- [x] if you changed code inside an experiment, make sure you bump its
version number

## Description

Changes to the ECHCheck experiment.

* Replace default URL with cloudflare-ech.com
* Add support for performing an additional ECH handshake with a
different ClientHelloOuter SNI
* Randomize the order of the handshakes
hellais added a commit to ooni/data that referenced this pull request Nov 20, 2024
…_http_middlebox tables (#100)

* Add support for parsing ech related fields from TLS handshakes
* Add support for parsing ooni_run_link_id
xref: ooni/spec#297

@DecFox DecFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hellais
hellais merged commit fcbf470 into master Nov 20, 2024
@hellais
hellais deleted the echcheck branch November 20, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants