[OPAL-9463] Adding PR guidelines to the onprem repo#7
Merged
Conversation
audrei-opal
changed the title
evan-opal
previously approved these changes
Feb 22, 2024
|
|
||
| > What is the level of risk to the product with this change? And why? (Low, High) | ||
|
|
||
| <!-- High areas of risk would include infrastructure changes, including DB migrations, changing how users get access to resources, potential side effects for no-prem customers, breaking changes to the public API, etc --> |
Collaborator
There was a problem hiding this comment.
nit: no-prem should be on-prem
audrei-opal
force-pushed
the
audrei-vs-repo-guidelines
branch
from
February 22, 2024 19:24
c1a2ec9 to
d45e70e
Compare
Contributor
Author
|
@evan-opal would you mind taking another look? I turned on dismissing approvals if changes are pushed 😬 |
evan-opal
approved these changes
Feb 22, 2024
evan-opal
left a comment
evan-opal
left a comment
Collaborator
There was a problem hiding this comment.
lgtm. I assume that even though this repo is public, we're still only expecting Opal engineers to create PRs here.
Contributor
Author
@evan-opal That's my current understanding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding some protections to the onprem repo ✨
Release Notes Description
N/A
Risk
Low
Testing
N/A
Checklist