escape sql variables #1037
Merged
escape sql variables #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance test results:
Updated: 2025-12-08T16:43:54.650Z SHA: 1556531 |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes OpenSQL statements by adding the @ escape character to SQL variables, converting from legacy ABAP syntax to the modern ABAP 7.40+ syntax. This improves code clarity by explicitly marking host variables in SQL statements.
- Updated all SELECT statements to use
@prefix for INTO clauses - Updated INSERT statement to use
@prefix for data source - Applied changes consistently across test and production code
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/unit/osql/cl_osql_test_environment.clas.testclasses.abap | Updated three SELECT statements in test method to use @ escape character for host variables |
| src/unit/osql/cl_osql_test_environment.clas.abap | Updated SELECT and INSERT statements to use @ escape character for host variables in validation and data insertion methods |
| src/oo/cl_oo_factory.clas.abap | Updated SELECT statement to use @ escape character for both the INTO clause and WHERE condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.