Skip to content

escape sql variables #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larshp merged 1 commit into from
Dec 8, 2025
Merged

escape sql variables #1037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/oo/cl_oo_factory.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ CLASS cl_oo_factory IMPLEMENTATION.

METHOD if_oo_clif_source~get_source.
DATA ls_data TYPE reposrc.
SELECT SINGLE * FROM reposrc INTO ls_data WHERE progname = mv_name.
SELECT SINGLE * FROM reposrc INTO @ls_data WHERE progname = @mv_name.
SPLIT ls_data-data AT |\n| INTO TABLE source.
ENDMETHOD.
ENDCLASS.
4 changes: 2 additions & 2 deletions src/unit/osql/cl_osql_test_environment.clas.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ CLASS cl_osql_test_environment IMPLEMENTATION.
TRY.
CREATE DATA ref TYPE (lv_table).
ASSIGN ref->* TO <fs>.
SELECT SINGLE * FROM (lv_table) INTO <fs>.
SELECT SINGLE * FROM (lv_table) INTO @<fs>.
CATCH cx_sy_create_data_error cx_sy_dynamic_osql_semantics.
WRITE '@KERNEL throw new Error(`table ${lv_table.get().trimEnd()} invalid or does not exist`);'.
ENDTRY.
Expand Down Expand Up @@ -124,7 +124,7 @@ CLASS cl_osql_test_environment IMPLEMENTATION.
READ TABLE mt_tables WITH KEY table_line = lv_table TRANSPORTING NO FIELDS.
ASSERT sy-subrc = 0.

INSERT (lv_table) FROM TABLE i_data.
INSERT (lv_table) FROM TABLE @i_data.
ASSERT sy-subrc = 0.

ENDMETHOD.
Expand Down
6 changes: 3 additions & 3 deletions src/unit/osql/cl_osql_test_environment.clas.testclasses.abap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,23 +16,23 @@ CLASS ltcl_test IMPLEMENTATION.
DATA lt_after TYPE ty_tdevc.
DATA ls_row TYPE tdevc.

SELECT * FROM tdevc INTO TABLE lt_before ORDER BY PRIMARY KEY.
SELECT * FROM tdevc INTO TABLE @lt_before ORDER BY PRIMARY KEY.

APPEND 'TDEVC' TO lt_tables.
li_environment = cl_osql_test_environment=>create( lt_tables ).
ls_row-devclass = 'HELLO'.
INSERT ls_row INTO TABLE lt_insert.
li_environment->insert_test_data( lt_insert ).

SELECT * FROM tdevc INTO TABLE lt_double ORDER BY PRIMARY KEY.
SELECT * FROM tdevc INTO TABLE @lt_double ORDER BY PRIMARY KEY.
cl_abap_unit_assert=>assert_equals(
act = lt_double
exp = lt_insert ).

li_environment->destroy( ).

* check table is back to normal
SELECT * FROM tdevc INTO TABLE lt_after ORDER BY PRIMARY KEY.
SELECT * FROM tdevc INTO TABLE @lt_after ORDER BY PRIMARY KEY.
cl_abap_unit_assert=>assert_equals(
act = lt_after
exp = lt_before ).
Expand Down