Skip to content

v1.6.7 - Fix Spurious Warning Message

Choose a tag to compare

View all tags
@jwesleye jwesleye released this 31 Dec 17:28
· 89 commits to main since this release
v1.6.7
8ea71ff

v1.6.7 - Fix Spurious Warning Message

This patch release fixes a confusing warning message that appeared after every turn in v1.6.4+.

Bug Fixed

  • Spurious warning after each turn: Fixed "Summary generation failed - session cannot be resumed" appearing after every query
    • Root cause: The warning was shown whenever no summary existed, but v1.6.4 intentionally skips summary generation on incremental saves
    • Symptom: Confusing false-positive warning after every turn saying session cannot be resumed
    • Related: Side effect of v1.6.4's fix to prevent unnecessary summary generation

What Was Wrong

After v1.6.4 added generate_summary=False by default for incremental saves, the code showed a warning whenever summary is None. But since incremental saves intentionally don't generate summaries, this warning appeared on every turn even though nothing was wrong.

The Fix

Only show the warning when we actually tried to generate a summary but it failed:

elif generate_summary:
    # Only warn if we tried to generate a summary but it failed
    logger.warning("Session saved without summary - resume will not work")

Result

  • Incremental saves (after each turn): ✅ No warning (as intended)
  • Final save/compaction: ⚠️ Only warns if summary generation actually fails

Testing

  • All 318 tests passing
  • Clean linting and type checking

This eliminates the annoying false-positive warning while preserving the useful warning for actual failures.

Assets 4
Loading