refactor: make packageIsVerified() actually short-circuit - #101
Merged
Conversation
The `return` inside pkgVersion.files.forEach() only exited that iteration's callback, not the outer function, so it kept scanning every remaining file even after `verified` was already false. Harmless today (files arrays are capped at 256 by the validator) but flagged as a nitpick in an internal spec-compliance audit. Rewrote using files.every(), which is both the more direct expression of the "verified iff every file matches" semantic and actually short-circuits on the first non-matching file. Also adds this function's first test coverage (previously only exercised indirectly through fixtures that all happened to be verified=true). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
returninsidepkgVersion.files.forEach()only exited that iteration's callback, not the outer function, so it kept scanning every remaining file even afterverifiedwas alreadyfalse. Harmless today (files arrays are capped at 256 by the validator) but flagged as a nitpick in an internal spec-compliance audit.files.every(), which is both the more direct expression of the "verified iff every file matches" semantic and actually short-circuits on the first non-matching file.verified: true).Test plan
npm run checkpasses (format, lint, build, tests — 207/207)🤖 Generated with Claude Code