Make id fields required for all objects in arrays

[timgdavies]

As discussed in #630, and in relation to #232, any time where OCDS support an array of objects, the objects in the array should each have an id property, and this property should be required.

At present, this is not true of

• Organization
• OrganizationReference
• RelatedProcess
• Amendment

Making these fields required is backwards incompatible (data valid under X.x could be made invalid under X.x+1 as the result of stronger requirements).

These fields should be made required in OCDS 2.0, and in the meantime a warning added to validation processes.

[jpmckinney]

Noting that in core extensions, this is not true of: open-contracting/ocds-extensions#53

• ParticipationFee
• Lot
• LotGroup
• Enquiry

[duncandewhurst]

Following on from @jpmckinney's open-contracting/ocds-extensions#83 (comment) about making id required:

If the above works for Enquiry, we can try to do the same for lots and participation fees: #650 (comment)

• Participation Fee - Used by 5 publishers, only india_civic_data_lab has missing id (research: OCDS Downloads, Paraguay). I think that publication (Himachal Pradesh) has effectively lapsed - it hasn't been updated for 17 months - but we are supporting them on a new publication (Assam) so we can ask them to update the old one if needed?
• Lot - Used by 9 publishers, no missing id (research: OCDS Downloads, Paraguay)
• LotGroup - Not used by any publishers (research: OCDS Downloads, Paraguay)

Based on the above, I think we can make id required on these definitions. @jpmckinney sound good?

[jpmckinney]

Sounds good!