Skip to content

Update references for validation FQs - #1578

Merged
goodsong81 merged 2 commits into
feature/otxfrom
ad/compressed_refs
Feb 1, 2023
Merged

Update references for validation FQs #1578
goodsong81 merged 2 commits into
feature/otxfrom
ad/compressed_refs

Conversation

@AlexanderDokuchaev

Copy link
Copy Markdown
Contributor

No description provided.

@AlexanderDokuchaev
AlexanderDokuchaev requested a review from a team as a code owner January 28, 2023 12:53
@github-actions github-actions Bot added the TEST Any changes in tests label Jan 28, 2023
@goodsong81
goodsong81 requested a review from sungmanc January 31, 2023 01:14

@sungmanc sungmanc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quick correction !

When I executed E2E tests with anomaly tasks, I got results below, could you also check with other tasks (classification, anomaly, segmentation)?
image

To execute E2E tests, you could use pytest -s -v tests/e2e/cli/

@alexsu52

alexsu52 commented Jan 31, 2023

Copy link
Copy Markdown

Thanks for quick correction !

When I executed E2E tests with anomaly tasks, I got results below, could you also check with other tasks (classification, anomaly, segmentation)? image

To execute E2E tests, you could use pytest -s -v tests/e2e/cli/

What commit caused the tests to fail?

This PR does not touch classification, anomaly, segmentation tasks. The issue that you mentioned requires analyze and does not stop merge this PR.

@alexsu52
alexsu52 requested a review from sungmanc January 31, 2023 07:11
@sungmanc

Copy link
Copy Markdown
Contributor

What commit caused the tests to fail?

This PR does not touch classification, anomaly, segmentation tasks. The issue that you mentioned requires analyze and does not stop merge this PR.

This PR is just targeting the detection model's references. What I want to tell is we also need to change classification, anomaly, and segmentation's references. Above error is not related with any other commits.

@alexsu52

Copy link
Copy Markdown

This PR is just targeting the detection model's references. What I want to tell is we also need to change classification, anomaly, and segmentation's references. Above error is not related with any other commits.

What do you mean under "Above error is not related with any other commits."? I hope you merged the mentioned tests in the repository based on that tests passed.

@AlexanderDokuchaev

Copy link
Copy Markdown
Contributor Author

@alexsu52 @sungmanc
With anomaly, It's possible problem with ignored_scope, that was tested on previous openvino version. I will check, and update with PR.

@github-actions github-actions Bot added the ALGO Any changes in OTX Algo Tasks implementation label Jan 31, 2023
@AlexanderDokuchaev

Copy link
Copy Markdown
Contributor Author

@alexsu52 @sungmanc
Yes, problem was in name of layers, as result ignored_scope was incorrected.

Same problem in segmentation models, it will be fixed in another pr.

@sungmanc

sungmanc commented Feb 1, 2023

Copy link
Copy Markdown
Contributor

This PR is just targeting the detection model's references. What I want to tell is we also need to change classification, anomaly, and segmentation's references. Above error is not related with any other commits.

What do you mean under "Above error is not related with any other commits."? I hope you merged the mentioned tests in the repository based on that tests passed.

Since this PR only changes the references for the detection task except for other tasks (classification, segmentation, ...), I met errors when I executed the E2E tests for overall tasks. So, I shared the error message example (anomaly case, attached above).

"Above error is not related with any other commits" means this PR couldn't cover all tasks. I'm sorry this sentence might be misleading.

@AlexanderDokuchaev , Thanks for checking the anomaly task, as you said, please make another PR for other tasks (segmentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants