Fix zoom and channel scaling in Headstage64 dialogs #526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- For Headstage64 Optical/Electrical stimulators, vertical zoom is disabled, which can interfere with the default behavior of the StimulusSequenceDialog to zoom in on the center of the cursor - The waveforms for both optical and electrical stimulators were not being properly scaled; the ChannelScale value was not applied at the correct location
cjsha
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While creating documentation for the Headstage64 GUIs, I found another error that slipped in, which is that the zoom and channel scaling for both dialogs were slightly shifted. This PR corrects both of those issues by checking if vertical zoom is enabled before zooming in on the center of the cursor, and by applying the ChannelScale correction at the correct place.