Allow NeuropixelsV2 headstages to run without any probes #535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of checking in the Configure node for the probe connection, move the check to the data node
aacuevas
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the check for a valid serial number from the Configure node to the data node, and removes the check that at least one probe has a valid serial number. This allows configuration to still continue, and the BNO data can be streamed.
The check for a valid serial number in the Data node ensures that if a data node is placed, it will confirm if the probe is connected at that time.
This is separate from issue #506, which will be addressed in a separate PR.
Fixes #505
This PR is tested on a NeuropixelsV2e headstage, with no probes connected, and the BNO data is still configured and streaming. If a data node is placed for the Neuropixels probe, it will throw an exception that the probe is missing, but if no data nodes are placed except for the Bno055 node, it will work correctly.