Ensure gain correction always exists for NeuropixelsV2e devices #536
      
        
          +6
        
        
          −6
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
This PR is based on the changes made in #535, and goes a step further to ensure that the gain correction is non-null, throwing an explicit exception if it is ever null so that the error message is useful.
However, during testing it was noted that #535 actually made it difficult to test this PR. If the issue-505 branch is removed, then these modifications correctly handle the case initially described in the issue where the gain correction value could be null. Nominally though, there should never be a case in the Data* nodes where the serial number exists but the gain correction value is null, since that condition is explicitly tested for in the Configure* nodes.
Fixes #506