Fix eventData size limit of 255 bytes#117
Merged
aacuevas merged 1 commit intoopen-ephys:developmentfrom Mar 6, 2017
Merged
Conversation
* Overflow could be easily triggered by sending a long message via the message center
Collaborator
|
This is the kind of changes I need to triple-check to be sure it doesn't break something obscure, but thanks for the patch. However, I won't be too worried about events right now. I've been working on a revamp of the channel and event systems which is almost ready to be merged into development. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an overflow that could be easily triggered by sending a long message via the message center (bottom bar in the GUI), resulting in only some fraction of the message being written to the messages file. Note that this triggers a recompile of a bunch of (presumably dependent) modules. Not sure if changing the data type of numBytes from uint8 to int has some other knock-on effects that I'm unaware of. Seems to work, so far.