Development#160
Merged
jsiegle merged 4 commits intoopen-ephys:developmentfrom Sep 3, 2017
Merged
Conversation
Analysis: This bug is there for following reasons. 1.ElectrodeButton for channels is directly added to the ChannelMappingEditor component. 2.When we drag the button we set the visibility of the lastHoverButton which makes it visible and shows on top of other components. 3. Also finding the correct button Logic is not proper as we are not considering the buttons which are scrolled up and invisible. Solution: 1. Create Viewport for holding the ElectrodeButton for channels. 2. Also create a Holder Component to hold all ElectrodeButton. 3. Add the ElectrodeButton to Holder Component and set the size of the Holder Component to fit all buttons. 4. Set setViewPosition for Viewport based on the scroll and drag. More Improvement: 1. We can remove upButton and downButton. 2. Viewport has its own scrolling which can be used for scrolling. Currently its been hidden using code "electrodeButtonViewport->setScrollBarsShown(false,false,true,true);"
Analysis: This bug is there for following reasons. 1.ElectrodeButton for channels is directly added to the ChannelMappingEditor component. 2.When we drag the button we set the visibility of the lastHoverButton which makes it visible and shows on top of other components. 3. Also finding the correct button Logic is not proper as we are not considering the buttons which are scrolled up and invisible. Solution: 1. Create Viewport for holding the ElectrodeButton for channels. 2. Also create a Holder Component to hold all ElectrodeButton. 3. Add the ElectrodeButton to Holder Component and set the size of the Holder Component to fit all buttons. 4. Set setViewPosition for Viewport based on the scroll and drag. More Improvement: 1. We can remove upButton and downButton. 2. Viewport has its own scrolling which can be used for scrolling. Currently its been hidden using code "electrodeButtonViewport->setScrollBarsShown(false,false,true,true);"
Member
|
Thanks a lot! This fixes the issue with the electrode buttons appearing in strange places, but now it's scrolling very slowly in "REMAP" mode. Can you try to figure out what's going on there? |
Contributor
Author
|
Can you elaborate more on this. |
Member
|
On my Linux machine, scrolling works fine until you switch to "REMAP" mode. Then, moving the scroll wheel moves the electrode buttons at a fraction of the normal speed. If you're not seeing this on your computer, then maybe it's a platform-specific issue. |
Analysis: This bug is there for following reasons. 1.ElectrodeButton for channels is directly added to the ChannelMappingEditor component. 2.When we drag the button we set the visibility of the lastHoverButton which makes it visible and shows on top of other components. 3. Also finding the correct button Logic is not proper as we are not considering the buttons which are scrolled up and invisible. Solution: 1. Create Viewport for holding the ElectrodeButton for channels. 2. Also create a Holder Component to hold all ElectrodeButton. 3. Add the ElectrodeButton to Holder Component and set the size of the Holder Component to fit all buttons. 4. Set setViewPosition for Viewport based on the scroll and drag. More Improvement: 1. We can remove upButton and downButton. 2. Viewport has its own scrolling which can be used for scrolling. Currently its been hidden using code "electrodeButtonViewport->setScrollBarsShown(false,false,true,true);" Implemented the improvements. Removed the upButton and DownButton. We have scrolling bar on the right to do the same. � Now scrolling in Remap works fine.
Contributor
Author
|
Fixed the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug #65.
Analysis:
This bug is there for following reasons.
1.ElectrodeButton for channels is directly added to the ChannelMappingEditor component.
2.When we drag the button we set the visibility of the lastHoverButton which makes it visible and shows on top of other components.
3. Also finding the correct button Logic is not proper as we are not considering the buttons which are scrolled up and invisible.
Solution:
More Improvement:
Please review and let me know the feedback @jsiegle