Skip to content

Some more Pulse Pal fixes#192

Merged
aacuevas merged 3 commits intoopen-ephys:developmentfrom
tne-lab:development
Feb 5, 2018
Merged

Some more Pulse Pal fixes#192
aacuevas merged 3 commits intoopen-ephys:developmentfrom
tne-lab:development

Conversation

@ethanbb
Copy link
Copy Markdown
Contributor

@ethanbb ethanbb commented Dec 27, 2017

Hi,

Changes to the Pulse Pal Output project:

  • Added canvas sources to the "source files" for VS so it would compile
  • Added loop variable initializations in PulsePalOutputCanvas.cpp

@ethanbb
Copy link
Copy Markdown
Contributor Author

ethanbb commented Feb 5, 2018

Got rid of the visual studio file changes since they've since been fixed on development. It looks like these changes in PulsePalOutputCanvas.cpp are still necessary though - I get a runtime error without them when opening the Pulse Pal window or tab in Windows.

@aacuevas aacuevas merged commit 9c2f6c3 into open-ephys:development Feb 5, 2018
@ethanbb
Copy link
Copy Markdown
Contributor Author

ethanbb commented Feb 5, 2018

That was fast!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants