Fix 'drawableSubprocessor' not being set when not loading settings or explicitly selecting a subprocessor#212
Merged
jsiegle merged 1 commit intoopen-ephys:developmentfrom Apr 30, 2018
Conversation
Member
|
Thanks for sorting this out! I've been trying to track down the cause of this for a while. |
Contributor
Author
|
No problem! Now just trying to figure out why TTL events sometimes aren't showing up... |
Member
|
What does your subprocessor configuration look like? @aacuevas created a source with reconfigurable subprocessor streams/sample rates that could be useful for testing. |
Contributor
Author
|
Actually never mind, looks like my problem was that I had the event channel turned off in the LFP viewer settings...thanks for helping me take a step back, I was getting pretty frustrated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the LFP viewer has a bug where the canvas's
drawableSubprocessorfield doesn't get set in the typical case of adding a new LFP viewer to a signal chain and not selecting a subprocessor from the ComboBox. TheupdateSubprocessorSelectorOptionsmethod selects the default subprocessor to display in the ComboBox, but doesn't send a notification, which is a problem because the ComboBox listener is responsible for settingdrawableSubprocessor. The end result is that the canvas does not refresh properly and the data does not get displayed.This fixes the bug by making
updateSubprocessorSelectorOptionssend a notification, and getting rid of a resulting circular call toupdateSettingswhich should never be necessary, given the contexts in which the containing functionLfpDisplayNode::setSubprocessoris currently called. The other change just removes a call toupdateSubprocessorSelectorOptionswhich seems to be redundant with line 88 in that file.