Save gain, reference and affected channel state in CAR plugin#221
Merged
jsiegle merged 1 commit intoopen-ephys:developmentfrom May 16, 2018
Merged
Save gain, reference and affected channel state in CAR plugin#221jsiegle merged 1 commit intoopen-ephys:developmentfrom
jsiegle merged 1 commit intoopen-ephys:developmentfrom
Conversation
Contributor
Author
|
Yeah, sorry. I misread that other issue, didn't realize it was about something else which still isn't fixed. |
Member
|
Actually, I might be confused. I didn't realize I was looking at PR I thought I was in issues still. Let me try to compile development and see if its actually fixed. |
Member
|
OK, yeah so this is specifically for the CAR plugin, correct? The channel map also does not save reference channels which was what #199 refers to. |
Contributor
Author
|
Yup, exactly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it says on the tin - save the Common Avg Ref parameters to XML (gain in an editor custom attribute and reference/affected channels in each channel's custom attributes).