Skip to content

Fix bug where PulsePal trigger and gate selections change on update#247

Merged
aacuevas merged 4 commits intoopen-ephys:testingfrom
tne-lab:pulsepal-combobox-fix
Sep 17, 2018
Merged

Fix bug where PulsePal trigger and gate selections change on update#247
aacuevas merged 4 commits intoopen-ephys:testingfrom
tne-lab:pulsepal-combobox-fix

Conversation

@ethanbb
Copy link
Copy Markdown
Contributor

@ethanbb ethanbb commented Jul 27, 2018

There was a bug in the PulsePal plugin where the selections in the editor ComboBoxes would decrease by one index every time there was a signal chain update (unless they were already at index 0).

To reproduce:

  • Add a Rhythm FPGA source followed by a PulsePal output
  • Select some TTL channels in the PulsePal editor ComboBoxes
  • Click the "ADC 1-8" button on and off to trigger signal chain updates.
  • Every time the button is clicked, the ComboBox selections will change until they're back to saying "Trigger" and "Gate".

The error was in the comboBoxChanged listener, where in lines 212 and 221, m_triggerSelected and m_gateSelected are assigned the selected ID minus 1, where elsewhere they're expected to contain the selected ID. I've changed it to always assign the selected ID to these variables, unless there is nothing selected (ID 0) in which case it assigns 1.

@ethanbb ethanbb changed the base branch from development to testing September 10, 2018 18:33
@ethanbb ethanbb force-pushed the pulsepal-combobox-fix branch from 419877a to 184cc10 Compare September 10, 2018 18:41
@aacuevas aacuevas merged commit 92b8dff into open-ephys:testing Sep 17, 2018
@ethanbb ethanbb deleted the pulsepal-combobox-fix branch September 20, 2018 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants