Fix bug where PulsePal trigger and gate selections change on update#247
Merged
aacuevas merged 4 commits intoopen-ephys:testingfrom Sep 17, 2018
Merged
Fix bug where PulsePal trigger and gate selections change on update#247aacuevas merged 4 commits intoopen-ephys:testingfrom
aacuevas merged 4 commits intoopen-ephys:testingfrom
Conversation
Add float and double cases where missing in InfoObjects
419877a to
184cc10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in the PulsePal plugin where the selections in the editor ComboBoxes would decrease by one index every time there was a signal chain update (unless they were already at index 0).
To reproduce:
The error was in the comboBoxChanged listener, where in lines 212 and 221,
m_triggerSelectedandm_gateSelectedare assigned the selected ID minus 1, where elsewhere they're expected to contain the selected ID. I've changed it to always assign the selected ID to these variables, unless there is nothing selected (ID 0) in which case it assigns 1.