Fix crash when clicking on LFP viewer canvas with no channels#273
Merged
aacuevas merged 1 commit intoopen-ephys:developmentfrom Dec 11, 2018
Merged
Fix crash when clicking on LFP viewer canvas with no channels#273aacuevas merged 1 commit intoopen-ephys:developmentfrom
aacuevas merged 1 commit intoopen-ephys:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash due to an out-of-bounds array access when clicking on a (blank) LFP Viewer canvas with no input channels. Previously, the
LfpDisplay'smouseDownlistener function would default to trying to select the 6th channel even though there are actually no channels to select. This function could probably be rewritten, which someone else is welcome to do before merging, but this is the minimal change to prevent this invalid behavior from happening.