Use SharedResourcePointers for ZeroMQ contexts#278
Merged
aacuevas merged 1 commit intoopen-ephys:developmentfrom Jan 6, 2019
Merged
Use SharedResourcePointers for ZeroMQ contexts#278aacuevas merged 1 commit intoopen-ephys:developmentfrom
aacuevas merged 1 commit intoopen-ephys:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was just browsing the JUCE library and I realized that this
SharedResourcePointerclass does exactly what we want for the ZeroMQ context, i.e. share a single instance among all owners automatically and also destroy it automatically when all the pointers are gone. So using this, we don't have to awkwardly set/read the static bare pointer to keep all instances using the same context. Looks nicer and the intent is clearer.As an aside, since these two plugins have a lot of duplicated functionality in their context and socket classes, maybe those should be pulled into a common library at some point.
Also fixes a minor issue with the network events restart connection button not always trying to reconnect to the currently bound port.
And yes I now have no life. Happy holidays everyone!