Fix saving chains starting with splitter and simplify#280
Merged
aacuevas merged 1 commit intoopen-ephys:developmentfrom Jan 6, 2019
Merged
Fix saving chains starting with splitter and simplify#280aacuevas merged 1 commit intoopen-ephys:developmentfrom
aacuevas merged 1 commit intoopen-ephys:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, saving a signal chain that starts with a splitter only saves the first branch. The first processor in a chain isn't handled specially if it is a splitter, as splitters encountered later in the chain are. Even though chains that don't start with a source can't be played, I still think it's important to save and load any signal chain correctly to minimize frustration.
I also took the opportunity to make a couple simplifications to make the saving code easier to understand. For instance, mergers are never saved in
splitPointsanymore, so all the special logic for when a processor insplitPointsis a merger was unreachable code and could be deleted.And I know the signal chain is being revamped, so this would be a temporary fix.